Re: [Libvir] [patch 6/9] Move iptablesSpawn()
On Mon, Jan 07, 2008 at 10:02:20AM +0000, Mark McLoughlin wrote:
On Sat, 2008-01-05 at 00:11 +0000, Daniel P. Berrange wrote:
> On Fri, Jan 04, 2008 at 03:57:31PM +0000, Mark McLoughlin wrote:
> > The next patch requires iptablesSpawn() higher up in
> > the file. This patch just moves the code around; there
> > is no functional change.
>
> The util.c file has a virExec function, although its a little more
> cumbersome to use than iptablesSpawn. So for the storage APIs I've
> got a new virRun() function in util.c which is very similar to your
> iptablesSpawn code. How about we just make iptables use the virRun
> method in the attached patch ?
Okay, the only thing lost with this is that when using WITH_ERRORS,
iptables error spew would go to libvirtd stderr, now it goes
to /dev/null. No big deal.
Well when we start libvirtd from the init script, its stderr gets pointed
to /dev/null anyway, so you end up with same effect. The only difference
would be for developers debugging. Perhaps we could make virRun spew
stuff to stderr if libvirt is built with --enable-debug.
Regards
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|