On 01/17/2018 12:37 PM, Daniel P. Berrange wrote:
This wires up the previously added OEM strings XML schema to be able to generate comamnd line args for QEMU. This requires QEMU >= 2.12 release containing this patch:
commit 2d6dcbf93fb01b4a7f45a93d276d4d74b16392dd Author: Daniel P. Berrange <berrange@redhat.com> Date: Sat Oct 28 21:51:36 2017 +0100
smbios: support setting OEM strings table
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/qemu/qemu_command.c | 28 ++++++++++++++++++++++++++++ tests/qemuxml2argvdata/smbios.args | 2 ++ tests/qemuxml2argvdata/smbios.xml | 5 +++++ tests/qemuxml2xmloutdata/smbios.xml | 5 +++++ 4 files changed, 40 insertions(+)
Would a QEMU < 2.12 cause a failure if the 'type=11' OEM strings were provided or do we need to add a capability in virQEMUCapsInitQMPMonitor based on version? What's here looks good and the provisional Reviewed-by: John Ferlan <jferlan@redhat.com> if we don't need the capability. If we need it, then probably need to update the patch. John