Re: [libvirt] [PATCH 1/2] build: properly handle ./configure --with-libpcap
On 12/13/2010 06:44 AM, Diego Elio Pettenò wrote:
Without this fix, ./configure --with-libpcap will cause
--with-libpcap=yes
to be implicitly passed down, which cause yes/bin/pcap-config to be
searched for rather than /usr/bin/pcap-config.
Also output pcap: no when pcap is not found or disabled.
---
configure.ac | 30 ++++++++++++++++--------------
1 files changed, 16 insertions(+), 14 deletions(-)
You forgot to run 'make syntax-check', which flagged a problem here:
@@ -2406,7 +2408,7 @@ AC_MSG_NOTICE([ xmlrpc: $XMLRPC_CFLAGS
$XMLRPC_LIBS])
else
AC_MSG_NOTICE([ xmlrpc: no])
fi
-if test "$with_qemu" = "yes" ; then
+if test "$with_qemu" = "yes" -a "$LIBPCAP_FOUND" !=
"no"; then
This must be test abc && test xyz, not test abc -a xyz, to avoid
portability problems.
ACK with that nit fixed, so I pushed it.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)