On Fri, Jan 16, 2009 at 12:59:59PM +0000, John Levon wrote:
On Fri, Jan 16, 2009 at 08:35:16AM +0100, Daniel Veillard wrote:
The comment and the code don't seems to match, and it seems to me
Oops, will fix the comment.
that this code would fail except in the first time the daemon is launched because mkdir /var/run/libvirt will return -1 and errno EEXIST in all following cases. I'm worried about this,
What do you mean? /var/run is a tmpfs on Solaris so must mkdir after every reboot.
I don't see any #ifdef __sun around that part of the patch, so I assume it need to be valid for all OSes. Moreover if you kill and restart the daemon, I would assume that chunk to fail too. So this need to be fixed IMHO before commit. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/