Re: [libvirt] [PATCH 2/2] node_device: avoid null dereference on error

11 May 2011


      On 05/11/2011 10:26 AM, Laine Stump wrote:
...
On 05/04/2011 07:37 PM, Eric Blake wrote:
...
If we plow on after udev_device_get_syspath fails, we will hit a NULL
dereference.  Clang found one due to strdup later in udevSetParent,
but in fact we hit a NULL dereference sooner because of the use of
STREQ within virNodeDeviceFindBySysfsPath.
* src/conf/node_device_conf.h (virNodeDeviceFindBySysfsPath): Mark
path argument non-null.
* src/node_device/node_device_udev.c (udevSetParent): Avoid null
dereference.
ACK.
Thanks; pushed.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org