Re: [libvirt] [libvirt-php][PATCH 2/2] configure.ac: Slightly rework

Firstly, AC_INIT() macro accepts more arguments than we currently pass. Then, it's considered a good practice to specify AC_CONFIG_SRCDIR() too. The rest is just some reorganization so that common things are close to each other rather than distributed randomly in the file. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- configure.ac | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 51a2cfe..2549b55 100644 --- a/configure.ac +++ b/configure.ac @@ -1,6 +1,7 @@ -AC_INIT([libvirt-php], [0.5.1], [http://libvirt.org]) +AC_INIT([libvirt-php], [0.5.1], [libvir-list(a)redhat.com], [], [http://libvirt.org]) +AC_CONFIG_SRCDIR([src/libvirt-php.c]) +AC_CONFIG_HEADERS([config.h]) AM_INIT_AUTOMAKE([-Wall -Werror -Wno-portability]) -AC_CONFIG_FILES([Makefile tools/Makefile src/Makefile tests/Makefile docs/Makefile]) AM_MAINTAINER_MODE([enable]) m4_ifndef([LT_INIT], [ @@ -157,10 +158,10 @@ if test "$OS" = "Darwin"; then else SHLIB_FLAGS="-shared -rdynamic" fi -AC_SUBST([SHLIB_FLAGS]) +AC_SUBST([SHLIB_FLAGS]) AC_SUBST([PHPIZE]) AC_SUBST([PHPCONFIG]) -AC_CONFIG_HEADERS([config.h]) -AC_CONFIG_FILES([libvirt-php.spec]) +AC_CONFIG_FILES([Makefile tools/Makefile src/Makefile \ + tests/Makefile docs/Makefile libvirt-php.spec]) AC_OUTPUT -- 2.7.3