Re: [libvirt] [PATCH 1/2] lxc: Coverity false positive USE_AFTER_FREE

On 05/01/2013 11:53 AM, John Ferlan wrote: > --- > src/lxc/lxc_container.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c > index ac0f69c..d082a06 100644 > --- a/src/lxc/lxc_container.c > +++ b/src/lxc/lxc_container.c > @@ -1772,6 +1772,11 @@ static int lxcContainerSetupPivotRoot(virDomainDefPtr vmDef, > /* Some versions of Linux kernel don't let you overmount > * the selinux filesystem, so make sure we kill it first > */ > + /* Filed coverity bug for false positive 'USE_AFTER_FREE' due to swap > + * of root->src with root->dst and the VIR_FREE(root->src) prior to the > + * reset of root->src in lxcContainerPrepareRoot() > + */ > + /* coverity[deref_arg] */ > if (STREQ(root->src, "/") && > lxcContainerUnmountSubtree(SELINUX_MOUNT, false) < 0) > goto cleanup; > ping? Any thoughts on this - either way? There is a Coverity bug filed, but it'll take some time to work through their system.