On 12/21/2012 10:08 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
Add the infrastructure for the libvirt-lxc.la library to
the remote protocol client and daemon
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
daemon/Makefile.am | 13 +++++-
daemon/libvirtd.c | 14 ++++++
daemon/libvirtd.h | 1 +
daemon/remote.c | 52 +++++++++++++++++++++
daemon/remote.h | 3 ++
src/Makefile.am | 15 +++++-
src/remote/lxc_protocol.x | 50 ++++++++++++++++++++
src/remote/remote_driver.c | 112 ++++++++++++++++++++++++++++++++++++---------
8 files changed, 235 insertions(+), 25 deletions(-)
create mode 100644 src/remote/lxc_protocol.x
@@ -382,7 +392,7 @@ check-protocol: $(PROTOCOL_STRUCTS)
$(PROTOCOL_STRUCTS:structs=struct)
# The .o file that pdwtags parses is created as a side effect of running
# libtool; but from make's perspective we depend on the .lo file.
-$(srcdir)/remote_protocol-struct $(srcdir)/qemu_protocol-struct: \
+$(srcdir)/remote_protocol-struct $(srcdir)/qemu_protocol-struct
$(srcdir)/lxc_protocol-struct: \
$(srcdir)/%-struct: libvirt_driver_remote_la-%.lo
This line is long, and we already used \-newline to break it; it's
probably worth trying to keep it within 80 columns.
+++ b/src/remote/lxc_protocol.x
@@ -0,0 +1,50 @@
+/* -*- c -*-
+ * lxc_protocol.x: private protocol for communicating between
+ * remote_internal driver and libvirtd. This protocol is
+ * internal and may change at any time.
+ *
+ * Copyright (C) 2010-2012 Red Hat, Inc.
also 2013
+ *
+ * Author: Chris Lalancette <clalance(a)redhat.com>
Really? There's so little left of his original .x that this feels like
stale copy and paste.
+ */
+
+%#include "internal.h"
+%#include "remote_protocol.h"
+%#include <arpa/inet.h>
Why <arpa/inet.h>?
ACK with those things fixed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org