On 04/18/2013 06:21 AM, harryxiyou wrote:
On Thu, Apr 18, 2013 at 5:30 PM, Daniel P. Berrange
<berrange(a)redhat.com> wrote:
> On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxiyou(a)gmail.com wrote:
>> From: Harry Wei <harryxiyou(a)gmail.com>
>>
>> Vol-rename is a convenience function, requiring when
>> one wanna rename a volume name.
>>
>> Signed-off-by: Harry Wei <harryxiyou(a)gmail.com>
>> ---
>> tools/virsh-volume.c | 103 ++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 103 insertions(+)
>
> NACK copying & deleting volumes is totally not what people
> want from a "rename" command.
>
Hmmm..., maybe this is not direct for us. However, i am not sure
about what kind of "rename" command we need. Actually, i am
investigating what kind of "rename" we need. Let me give another
way.
Only change the name of volume and need not copying and
deleting volume. To back-end storage volume(Offline storage),
Libvirt just call relevant storage driver and the storage volume(with
a volume name) is created by back-end storage driver. If we wanna
change the volume name without copying and deleting, we may
need give hook function to let back-end driver to realize relevant
driver for rename stuffs.
Exactly - we need to add a new libvirt API that can support renames at
the backend driver level, with instant effect (a directory pool
forwarding to rename(2), other pools using pool-specific renaming commands).
It might be worth still having virsh vol-rename have an option to do a
long-running copy/delete in the case of a backend that doesn't support
instant renames, but the default should be instant rename or failure.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org