Re: [PATCH 1/2] char: Skip CLI aliases in query-chardev-backends
Kevin Wolf <kwolf(a)redhat.com> writes:
Am 12.11.2020 um 09:22 hat Markus Armbruster geschrieben:
> Kevin Wolf <kwolf(a)redhat.com> writes:
>
> > The aliases "tty" and "parport" are only valid on the
command line, QMP
> > commands like chardev-add don't know them. query-chardev-backends should
> > describe QMP and therefore not include them in the list of available
> > backends.
> >
> > Signed-off-by: Kevin Wolf <kwolf(a)redhat.com>
>
> I'd call that a bug.
Which is why I'm fixing it, separate from the deprecation.
Thank you :)
> In the light of PATCH 2, I propose to put that one first (with
the
> help_string_append() hunk dropped), then remove the aliases from CLI
> help, too, like this: [...]
Going one step back without thinking in solutions immediately, what
you're suggesting is that deprecated options should become undocumented
instead of just annotated as deprecated?
"Should become" is open to debate. "Have become" is a fact:
3478eae990 "qemu-options: Deprecate -nodefconfig", 2017-10-09
80f52a6694 "Deprecate -M command line options", 2011-07-23
and more.
I don't see the why *help* output should mention deprecated options.
It's distracting. Tell me how to use this thing, not how I could use
it, but really shouldn't.
Mentioning them in the reference manual may have value.
Covering them in deprecated.rst is of course mandatory.