On Mon, Mar 30, 2015 at 10:54:14 -0600, Eric Blake wrote:
On 03/30/2015 09:41 AM, Peter Krempa wrote:
The block copy API takes the speed in bytes/s rather than MiB/s that was the prior approach in virDomainBlockRebase. We correctly converted the speed to bytes/s in the old API but we still called the common helper virDomainBlockCopyCommon with the unadjusted variable.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1207122 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
D'oh on my part. Probably snuck in while I was rebasing across several different attempts for the best normalization approach.
It's a shame that the compiler/optimizer doesn't warn that the value is not used after the assignment. Pushed; Thanks. Peter