On 01/23/2013 07:47 AM, Peter Krempa wrote:
virNetworkObjUpdateParseFile used ',' as the termination
character for
virBitmapParse. This would break if an incontiguous range would be
s/incontiguous/non-contiguous/
parsed.
---
src/conf/network_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 9c35ea8..c93916d 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -1856,7 +1856,7 @@ virNetworkObjUpdateParseFile(const char *filename,
ctxt->node = node;
class_id = virXPathString("string(./class_id[1]/@bitmap)", ctxt);
if (class_id &&
- virBitmapParse(class_id, ',',
+ virBitmapParse(class_id, 0,
&net->class_id, CLASS_ID_BITMAP_SIZE) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_("Malformed 'class_id' attribute: %s"),
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org