Re: [libvirt] [PATCH] Fix the style of argument("cpumap") in op_pincpu()

On Fri, May 08, 2009 at 06:45:59PM +0900, Tatsuro Enokura wrote: > > > Okay, but I'm still worrying. > > > The fact that we fail to detect the error NG1 is a bug, and that > > > bug should be fixed. Seems to me the change may just replace one error > > > by another one but in the end we should instead aim at fixing the NG1 > > > problem with the old format, not substituing it with something else. > > > > > > I would prefer if the patch did some checking about the current xend > > > version running, but unfortunately priv->xendConfigVersion won't be > > > precise enough. > > > > > > Sorry I don't know how to handle this more correctly right now > > I see. > priv->xendConfigVersion isn't appropriate for tracing the xend's > version. We should request to the xen community for new interface > of to get the xend's version. > > On other hand, > the new xend and libvirt without the cpumap patch occur error(NG2). > Behavior of the old xend and libvirt with the cpumap patch is the same > behavior of libvirt without the cpumap patch. > Moreover, there is no work for libvirt of this issue any further at present. > > I make the patch that added the foregoing content as TODO comment. > > Signed-off-by: Tatsuro Enokura <fj2026af(a)aa.jp.fujitsu.com&gt; Okay, here is my suggested patch to minimize impact on old xen setups maybe someone locally fixed the xend side, and we should at least try to not break it on old setups. So I updated the comment And activate the change only for version of xend >= 3 which won't cover the full range but should still protect some of the older setups,