Martin Kletzander wrote:
On Fri, Jul 17, 2015 at 08:23:07PM +0300, Roman Bogorodskiy wrote:
Currently, build fails on FreeBSD with:
CC libvirt_driver_la-nodeinfo.lo nodeinfo.c:1941:56: error: use of undeclared identifier 'SYSFS_SYSTEM_PATH' const char *prefix = sysfs_prefix ? sysfs_prefix : SYSFS_SYSTEM_PATH; ^ 1 error generated.
This is caused by commit b97b3048 that added sysfs_prefix to nodeCapsInitNUMA and used SYSFS_CPU_PATH.
Fix it by unconditionally defining SYSFS_CPU_PATH instead of defining it under #ifdef __linux__. --- src/nodeinfo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
ACK, can't hurt, could've been considered under build-breaker rule.
Pushed, thanks! I didn't forget about the build-breaker rule, however, there were no rush and I was wondering if somebody'd suggest a better fix. Roman Bogorodskiy