Re: [libvirt] [PATCH 00/22] syntax-check: Check misaligned stuff and fix them (batch II)

On Fri, Oct 05, 2018 at 04:11:23PM +0800, Shi Lei wrote: I was away when that series merged, but I'm not at all a fan of writing our own custom code for checking indentation. IMHO we should be just picking an existing tool such as either ident or clang-format, and providing a desired config for it. I've looked at clang-format before and it is pretty good. It does not have ability to quite match our code style, but I don't think that is a real show stopper. We'd be better off just adapting to one of the common code styles rather than inventing yet another app todo code indent analysis. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|