On Thu, Aug 02, 2018 at 10:17:32AM +0200, Bjoern Walk wrote:
Pino Toscano <ptoscano@redhat.com> [2018-08-02, 10:02AM +0200]:
I do not think this patch is correct: we are dealing with random bytes, so there is no "endianness" for them.
Well, it's not incorrect either, isn't it? I agree that endianness doesn't matter for random data, but in the same time, it doesn't hurt to have the same random data generated on big- and little-endian machines. And it gives an easy and future-proof fix for the mocked tests.
Lets just modijfy tests/virrandommock.c to add mocking of virRandomBits alongside virRandomBytes. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|