Re: [libvirt] PV loader in capabilities?

On Thu, Jul 10, 2008 at 09:08:33AM +0100, Daniel P. Berrange wrote: > On Thu, Jul 10, 2008 at 12:07:18AM +0100, John Levon wrote: > > > > Why is it NULL instead of the path to pygrub? On Solaris, the path is > > different. > > Loader is refering specifically to the <loader> tag which is a BIOS > firmware blob. virt-install code seems to disagree: elif self.boot_caps.loader == "pygrub" or (self.boot_caps.loader is None and self.boot_caps.type == "xen"): osblob += " </os>\n" osblob += " <bootloader>/usr/bin/pygrub</bootloader>" Now, if that's an error, that's fine. I have a patch on the way that fixes up the pygrub path based upon caps.host.arch when available (as this is always i86pc on Solaris).