Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

In the title: "qmp:" Peter Maydell <peter.maydell(a)linaro.org&gt; writes: > diff --git a/qapi/run-state.json b/qapi/run-state.json > index 9d34afa39e0..1de8c5c55d0 100644 > --- a/qapi/run-state.json > +++ b/qapi/run-state.json > @@ -104,16 +104,27 @@ > # > # @running: true if all VCPUs are runnable, false if not runnable > # > -# @singlestep: true if VCPUs are in single-step mode > +# @one-insn-per-tb: true if using TCG with one guest instruction > +# per translation block > +# > +# @singlestep: deprecated synonym for @one-insn-per-tb > # > # @status: the virtual machine @RunState > # > +# Features: > +# @deprecated: Member 'singlestep' is deprecated. Use @one-insn-per-tb instead. Wrap this line, please. > +# > # Since: 0.14 > # > -# Notes: @singlestep is enabled through the GDB stub > +# Notes: @one-insn-per-tb is enabled on the command line with > +# '-accel tcg,one-insn-per-tb=on', or with the HMP > +# 'one-insn-per-tb' command. > ## Hmm. We report it in query-status, which means it's relevant to QMP clients. We provide the command to control it only in HMP, which means it's not relevant to QMP clients. Why is reading it relevant to QMP clients, but not writing?

Use cases for reading it via QMP query-status? Have you considered tacking feature 'unstable' to it?

> { 'struct': 'StatusInfo', > - 'data': {'running': 'bool', 'singlestep': 'bool', 'status': 'RunState'} } > + 'data': {'running': 'bool', > + 'singlestep': { 'type': 'bool', 'features': [ 'deprecated' ]}, > + 'one-insn-per-tb': 'bool', > + 'status': 'RunState'} } > > ## > # @query-status: I see a bunch of query-status results in tests/qemu-iotests/{183,234,262,280}.out. Do they need an update?