21 Jun
2011
21 Jun
'11
2:21 p.m.
On 06/21/2011 01:16 PM, Eric Blake wrote:
On 06/21/2011 06:01 AM, Gerhard Stenzel wrote:
+ rc = ifaceGetMacaddr(linkdev, oldmac); + + if (rc) { + virReportSystemError(rc, Sorry for not catching this sooner. This should probably be virReportSystemError(errno,...), assuming that ifaceGetMacaddr guarantees a sane errno setting (at any rate, you used errno for ifaceSetMacaddr later on).
It should be ok the way it is since ifaceGetMacAddr() returns either EINVAL or the content of errno. Stefan
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list