-----Original Message----- From: Daniel P. Berrange [mailto:berrange@redhat.com] Sent: Tuesday, November 17, 2015 6:47 PM To: Ren, Qiaowei Cc: libvir-list@redhat.com; Jiri Denemark Subject: Re: [PATCH 0/8] Add perf and Intel CMT feature support
On Tue, Nov 17, 2015 at 04:00:40PM +0800, Qiaowei Ren wrote:
The series mainly adds Intel CMT feature support into libvirt. CMT is new introduced PQos (Platform Qos) feature to monitor the usage of cache by applications running on the platform.
Currently CMT patches has been merged into Linux kernel mainline. The CMT implementation in Linux kernel is based on perf mechanism and there is no support for perf in libvirt, and so this series firstly add perf support into libvirt, including two public API and a set of util interfaces. And based on these APIs and interfaces, thie series implements CMT perf event support.
TODO: 1. This series relys on keeping an open file descriptor for the guest. We should add one patch to call sys_perf_event_open again iff libvirtd is restarted.
I've not done a detailed patch review, but overall I think this design is pretty good now, so thanks for taking time to re-write this.
Daniel, thanks for your feedback. ^-^ Thanks, Qiaowei