Re: [PATCH 5/6] docs: Distribute the XMLs with ACL permission flags for APIs
On Mon, Feb 20, 2023 at 06:11:41PM +0100, Peter Krempa wrote:
On Mon, Feb 20, 2023 at 17:05:31 +0000, Daniel P. Berrangé wrote:
> On Mon, Feb 20, 2023 at 11:47:08AM +0100, Peter Krempa wrote:
> > Similarly to the API XML we can distribute the ACL permissions for the
> > APIs so that users who are potentially interested into the data don't
> > have to scrape our web.
>
> IMHO if we want to expose this to apps, we should be including
> the info directly in the API files we already ship, rather than
> exporting something new.
Yeah, I thought the same but didn't really fancy changing the generator
as they are partially generated by gendispatch rather than the ACL
generator as the information is in the protocol headers rather than with
the function headers.
Rather than change the python generator, it would be possible to use
an XSL transform to merge the ACL XML info into the main API info
doc. Whether that's better or not of course depends how much you
enjoy working with XSL :-)
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|