Re: [libvirt PATCH 2/5] meson: Use initconfdir
On Fri, May 05, 2023 at 01:34:50PM +0200, Martin Kletzander wrote:
On Tue, May 02, 2023 at 07:15:49PM +0200, Andrea Bolognani wrote:
> - if [ -r "$SYSCONFDIR"/sysconfig/iptables ]
> + if [ -r "$INITCONFDIR"/iptables ]
> then
> - if grep "$PORT" "$SYSCONFDIR"/sysconfig/iptables
>/dev/null 2>&1
> + if grep "$PORT" "$INITCONFDIR"/iptables >/dev/null
2>&1
This won't work on Gentoo for example which has only service
configuration options there, but since:
a) the check is not thorough at all
b) never worked there anyway
c) can't not work more than before
I think it's fine ;)
Yeah, the file doesn't exist at all on my Fedora machine, and the
documentation for RHEL 7 (!) says something about firewalld making it
obsolete. Debian doesn't seem to have it either.
The code has been the same since the script was introduced in 2009,
so I think it's just a consequence of the world changing around it.
We could probably look into dropping that part of the script, but
that's a task for someone else I think :)
--
Andrea Bolognani / Red Hat / Virtualization