On 3/12/19 1:01 PM, John Ferlan wrote:
On 3/7/19 12:47 AM, Eric Blake wrote:
Prepare for introducing a bunch of new public APIs related to backup checkpoints by first introducing a new internal type and errors associated with that type. Checkpoints are modeled heavily after virDomainSnapshotPtr (both represent a point in time of the guest), although a snapshot exists with the intent of rolling back to that state, while a checkpoint exists to make it possible to create an incremental backup at a later time.
Signed-off-by: Eric Blake <eblake@redhat.com>
--- v5: minor review tweaks [John] --- include/libvirt/virterror.h | 6 +++- src/util/virerror.c | 12 ++++++- include/libvirt/libvirt.h | 6 +++- src/datatypes.h | 31 +++++++++++++++++- src/datatypes.c | 63 ++++++++++++++++++++++++++++++++++++- src/libvirt_private.syms | 2 ++ 6 files changed, 115 insertions(+), 5 deletions(-)
Reviewed-by: John Ferlan <jferlan@redhat.com>
John
I think this is also separable....
I will stop here since it seems the rest could/would have changes based on other snapshot series posted, in various states of review, and being pushed. Mainly trying to clear a bit of the "future" queue ;-)
I know you said I could push this, but I ended up refactoring it to use a common base class instead. Next round of posts hitting the list soon... -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org