Re: [libvirt] [PATCH v2 3/5] qemu: Add vhost-scsi string for -device parameter

>> diff --git a/src/util/virscsi.c b/src/util/virscsi.c >> index 4843367..290b692 100644 >> --- a/src/util/virscsi.c >> +++ b/src/util/virscsi.c >> @@ -105,6 +105,32 @@ virSCSIDeviceGetAdapterId(const char *adapter, >> return -1; >> } >> +int >> +virSCSIOpenVhost(int *vhostfd, >> + size_t *vhostfdSize) > Well this is dangerous... I can pass "any" value value here and really > cause some damage. Why the need for a loop? Well, I guess I only half-cleaned it up. I'm not aware of any mechanism to pass multiple fd's for vhost-scsi-pci or vhost-scsi-ccw into QEMU (unlike the virtio-scsi-{ccw|pci} paths), so I started ripping the loops out. Looking at it now, I guess I didn't rip out nearly as much as I thought I did. So, more to remove I guess. Unless leaving it there for an "if the future ever arrives" case is a problem.