On 11/08/2010 12:27 PM, Daniel P. Berrange wrote:
This extends the SPICE XML to allow channel security options
<graphics type='spice' port='-1' tlsPort='-1' autoport='yes'> <channel name='main' mode='secure'/> <channel name='record' mode='insecure'/> </graphics>
Any non-specified channel uses the default, which allows both secure & insecure usage
* src/conf/domain_conf.c, src/conf/domain_conf.h, src/libvirt_private.syms: Add XML syntax for specifying per channel security options for spice. * src/qemu/qemu_conf.c: Configure channel security with spice
ACK series; except for my comments to patch 2/9, I think you covered all my findings from v1 of your series. And my comments to 2/9 don't invalidate the series, so much as provide suggestions for future patches to improve the series. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org