On Fri, Jul 08, 2011 at 01:34:05 +0200, Jiri Denemark wrote:
This series is also available at https://gitorious.org/~jirka/libvirt/jirka-staging/commits/migration-recover...
The series does several things: - persists current job and its phase in status xml - allows safe monitor commands to be run during migration/save/dump jobs - implements recovery when libvirtd is restarted while a job is active - consolidates some code and fixes bugs I found when working in the area
The series is not perfect and still needs some corner cases to be fixed but I think it's better to send the series for review now and add small additional fixes in the next version(s) instead of waiting for it to be perfect.
OK, I pushed the following patches (01-08/19 and 13/19) which were already acked. When doing so, I also updated documentation in src/qemu/THREADS.txt as part of the "qemu: Allow all query commands to be run during long jobs" patch. The diff to THREADS.txt is attached.
qemu: Separate job related data into a new object qemu: Consolidate BeginJob{,WithDriver} into a single method qemu: Consolidate {Enter,Exit}Monitor{,WithDriver} qemu: Allow all query commands to be run during long jobs qemu: Save job type in domain status XML qemu: Recover from interrupted jobs qemu: Add support for job phase qemu: Consolidate qemuMigrationPrepare{Direct,Tunnel} qemu: Fix monitor unlocking in some error paths
Jirka