Re: [libvirt] [jenkins-ci PATCH 3/6] projects: add gtk-vnc project
On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
[...]
+++ b/guests/playbooks/build/projects/gtk-vnc.yml
@@ -0,0 +1,12 @@
+---
+- set_fact:
+ name: gtk-vnc
+ machines: '{{ all_machines }}'
+ archive_format: gz
+ git_url: '{{ git_urls["gtk-vnc"][git_remote] }}'
+
+- include: '{{ playbook_base }}/jobs/prepare.yml'
+- include: '{{ playbook_base }}/jobs/autotools-build-job.yml'
+- include: '{{ playbook_base }}/jobs/autotools-syntax-check-job.yml'
+- include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
+- include: '{{ playbook_base }}/jobs/autotools-rpm-job.yml'
You need to do
- include: '{{ playbook_base }}/jobs/autotools-rpm-job.yml'
vars:
machines: '{{ rpm_machines }}'
here, or it will try (and obviously fail) to build RPMs on Debian,
Ubuntu and FreeBSD.
Same for the Jenkins equivalent, of course.
[...]
+++ b/guests/vars/projects/gtk-vnc.yml
@@ -0,0 +1,11 @@
+---
+packages:
+ - cyrus-sasl
+ - glib2
+ - gnutls
+ - gobject-introspection
+ - gtk3
+ - intltool
+ - libgcrypt
+ - pulseaudio
+ - vala
Please split all changes to guests/vars/ and guests/host_vars/ off
to a separate preparatory commit, similar to eg. 56c9e4a4b506.
Everything else looks good.
--
Andrea Bolognani / Red Hat / Virtualization