Re: [libvirt] [PATCH 00/10] tools: remove vshStrdup (glib chronicles)
On 10/19/19 12:55 PM, Ján Tomko wrote:
On Sat, Oct 19, 2019 at 07:21:15AM -0300, Daniel Henrique Barboza
wrote:
>
>
> On 10/18/19 7:37 PM, Ján Tomko wrote:
>> Ján Tomko (10):
>> tools: cmdDomblkinfoGet: reindent parameters
>> virsh: use g_strdup in cmdDomblkinfoGet
>> virsh: use g_strdup in virshDomainGetEditMetadata
>> virsh: getSignalNumber: rename variables
>> virsh: getSignalNumber: use g_autofree
>> virsh: getSignalNumber: use g_strdup
>> tools: vshCommandArgvGetArg: one parameter per line
>> tools: vshCommandArgvGetArg: prefer g_strdup
>> tools: prefer g_strdup to vshStrdup
>> tools: delete vshStrdup
>
>
> All patches:
>
> Reviewed-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>
>
>
> Question: I see that you're pushing the glib chronicles recently. Do
> you have plans to do the virAsprintf -> g_strdup_printf conversion?
>
> I am asking because I started this conversion yesterday, and the
> amount of calls to be converted is so massive that it's kind of funny.
> And it's not a work that I'll be able to full commit during the workday
mprivozn started working on that on Friday using Coccinelle, you need to
ask him. Chances are you already converted some usage that was not
simply caught by his spatch.
Nevermind then. I'll let Michal do that, then he can do it all at once
and we'll not duplicate efforts. Thanks for letting me know.
Personally I'm working on a branch that does VIR_STRDUP -> g_strdup.
> So, if this conversion is under your radar and you want to
https://en.wiktionary.org/wiki/under_the_radar
Owned. I meant 'on your radar' and wrote the opposite :P
DHB
Jano
> get it done ASAP (meaning that you'll get it done faster than I'm
> capable of), let me know and I'll stand down from pursuing that.
>