Re: [libvirt] [PATCH v3 0/9] Introduce display of IOThreads Information

On 02/17/2015 04:03 PM, John Ferlan wrote: > v2 here: > http://www.redhat.com/archives/libvir-list/2015-February/msg00562.html > > Changes over v2: > Patches 1-4 > * Add "resources" and "nresources" in order to return the resources that > are using an IOThread > * Fixed memory leak - neglected to free the qemuMonitorIOThreadsInfoPtr > 'iothreads' in patch 3 > > Patches 5-9 (NEW) > * Patches 5 & 6 implement the API/remote protocol for virDomainSetIOThreads > * Patch 7 implements a couple of helper function - copies of existing > vcpupin functions > * Patch 8 implements the qemu backend qemuDomainSetIOThreads in order to > allow setting IOThread pin data either for live or config. Heavily lifted > from existing vcpu code > * Patch 9 implements the virsh command options in order to set the pinning > on a specific thread. As a side effect/benefit one can now display just one > IOThread if so desired. > > All the changes are sufficient to satisfy the following bz: > > https://bugzilla.redhat.com/show_bug.cgi?id=1135491 > > John Ferlan (9): > Implement public API for virDomainGetIOThreadsInfo > remote: Implement the remote plumbing for virDomainGetIOThreadsInfo > qemu: Implement the qemu driver fetch for IOThreads > virsh: Add 'iothreads' command > Implement public API for virDomainSetIOThreads > remote: Implement remote plumbing for virDomainSetIOThreads > domain: Introduce virDomainIOThreadsPin{Add|Del} > qemu: Add qemuDomainSetIOThreads > virsh: Allow setting of the iothread pin > > daemon/remote.c | 99 +++++++- > include/libvirt/libvirt-domain.h | 48 +++- > src/conf/domain_conf.c | 64 +++++ > src/conf/domain_conf.h | 10 + > src/driver-hypervisor.h | 16 +- > src/libvirt-domain.c | 149 ++++++++++- > src/libvirt_private.syms | 2 + > src/libvirt_public.syms | 7 + > src/qemu/qemu_driver.c | 519 +++++++++++++++++++++++++++++++++++++++ > src/remote/remote_driver.c | 94 ++++++- > src/remote/remote_protocol.x | 48 +++- > src/remote_protocol-structs | 33 +++ > src/rpc/gendispatch.pl | 1 + > tools/virsh-domain.c | 154 ++++++++++++ > tools/virsh.pod | 20 ++ > 15 files changed, 1257 insertions(+), 7 deletions(-) > ping - although probably now not a 1.2.13 candidate with the freeze - if a review can be completed I could get it in early to 1.2.14...