Re: [libvirt] [PATCH 5/5] qemuDomainCreateDevice: Canonicalize paths

On 01/11/2017 06:04 PM, Daniel P. Berrange wrote: > On Wed, Jan 11, 2017 at 05:43:16PM +0100, Michal Privoznik wrote: >> So far the decision whether /dev/* entry is created in the qemu >> namespace is really simple: does the path starts with "/dev/"? >> This can be easily fooled by providing path like the following >> (for any considered device like disk, rng, chardev, ..): >> >> /dev/../var/lib/libvirt/images/disk.qcow2 > > Did you find someone/thing that was actually doing that ? No, but Martin asked me about that when talking about namespaces and I thought of trying that out. The domain startup did not fail, but only because of 3aae99fe71 which made mknod() not error out on EEXIST.