This patch breaks the error return value for:
virDomainControllerDefFormat()
virDomainSoundDefFormat()
virDomainMemballoonDefFormat()
Patch adds the "ret" variable but in error exit it use "return 0" statement.
Actually this breaks compilation.
Was this code compiled ?
conf/domain_conf.c: In function 'virDomainControllerDefFormat':
conf/domain_conf.c:24368:9: error: variable 'ret' set but not used [-Werror=unused-but-set-variable]
int ret = -1;
^~~
CC test/libvirt_driver_test_la-test_driver.lo
CC vmx/libvirt_vmx_la-vmx.lo
CC vmware/libvirt_driver_vmware_la-vmware_driver.lo
CC vmware/libvirt_driver_vmware_la-vmware_conf.lo
conf/domain_conf.c: In function 'virDomainSoundDefFormat':
conf/domain_conf.c:25882:9: error: variable 'ret' set but not used [-Werror=unused-but-set-variable]
int ret = -1;
^~~
conf/domain_conf.c: In function 'virDomainMemballoonDefFormat':
conf/domain_conf.c:25926:9: error: variable 'ret' set but not used [-Werror=unused-but-set-variable]
int ret = -1;
^~~