On Tue, Mar 31, 2009 at 11:36:51PM +0200, Daniel Veillard wrote:
On Tue, Mar 31, 2009 at 05:29:09PM +0200, Chris Lalancette wrote:
Can you try with this patch applied
diff -r b5ad7b1c453b src/qemu_driver.c --- a/src/qemu_driver.c Tue Mar 31 14:55:23 2009 +0100 +++ b/src/qemu_driver.c Tue Mar 31 15:02:30 2009 +0100 @@ -4629,7 +4629,7 @@ qemudDomainMigratePrepare2 (virConnectPt * URI when passing it to the qemu monitor, so bad * characters in hostname part don't matter. */ - if (!STREQLEN (uri_in, "tcp:", 6)) { + if (!STRPREFIX (uri_in, "tcp:")) { qemudReportError (dconn, NULL, NULL, VIR_ERR_INVALID_ARG, "%s", _("only tcp URIs are supported for KVM migrations")); goto cleanup;
Yeah, that's the way to fix this. The STREQLEN(uri_in, "tcp:", 6) is a leftover from the KVM migration to QEMU migration implementation; in the KVM migration, you would use "tcp://", which would be the correct 6 characters, but in the QEMU migration implementation, you just use "tcp:". I guess I just forgot to fix this up.
ACK, Dan can you apply this too ?
Yep, committed this now Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|