Re: [libvirt] [PATCH v2 10/15] qemufirmwaretest: Test qemuFirmwareFetchConfigs()
On Thu, Mar 07, 2019 at 10:29:20AM +0100, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
tests/Makefile.am | 1 +
.../etc/qemu/firmware/40-ovmf-sb-keys.json | 1 +
.../etc/qemu/firmware/60-ovmf-sb.json | 0
.../user/.config/qemu/firmware/10-bios.json | 0
.../share/qemu/firmware/40-bios.json} | 0
.../share/qemu/firmware/50-ovmf-sb-keys.json} | 0
.../share/qemu/firmware/60-ovmf-sb.json} | 0
.../share/qemu/firmware/61-ovmf.json} | 0
.../share/qemu/firmware/70-aavmf.json} | 0
tests/qemufirmwaretest.c | 72 +++++++++++++++++--
10 files changed, 68 insertions(+), 6 deletions(-)
create mode 120000 tests/qemufirmwaredata/etc/qemu/firmware/40-ovmf-sb-keys.json
create mode 100644 tests/qemufirmwaredata/etc/qemu/firmware/60-ovmf-sb.json
create mode 100644 tests/qemufirmwaredata/home/user/.config/qemu/firmware/10-bios.json
rename tests/qemufirmwaredata/{bios.json => usr/share/qemu/firmware/40-bios.json}
(100%)
rename tests/qemufirmwaredata/{ovmf-sb-keys.json =>
usr/share/qemu/firmware/50-ovmf-sb-keys.json} (100%)
rename tests/qemufirmwaredata/{ovmf-sb.json =>
usr/share/qemu/firmware/60-ovmf-sb.json} (100%)
rename tests/qemufirmwaredata/{ovmf.json => usr/share/qemu/firmware/61-ovmf.json}
(100%)
rename tests/qemufirmwaredata/{aavmf.json => usr/share/qemu/firmware/70-aavmf.json}
(100%)
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
}
-VIR_TEST_MAIN(mymain);
+VIR_TEST_MAIN(mymain)
Either this is an accidental change, or it should have been in the
previous patch. With that fixed
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|