Re: [libvirt] [PATCHv2] qemu: process: Refactor reconnecting to qemu processes

On Thu, Dec 04, 2014 at 02:40:46PM +0100, Peter Krempa wrote:

Move entering the job into the thread to simplify the program flow. Also as the code holds a separate reference to the domain object some conditions can be simplified. ---

Notes: Version 2: - fix leak of 'data' when not reconnecting

src/qemu/qemu_process.c | 161 ++++++++++++++++++++++-------------------------- 1 file changed, 72 insertions(+), 89 deletions(-)

You can also remove the qemuDomainObjTransferJob() if you want as that existed only because of the reconnect function. ACK either way, this looks much simpler now. Thanks, Martin