Re: [libvirt] [PATCH 1/2] virsh-completer: Separate comma list construction into a function

On Tue, Jun 18, 2019 at 03:46:15PM +0200, Michal Privoznik wrote: > There are more arguments than 'shutdown --mode' that accept a > list of strings separated by commas. 'nodedev-list --cap' is one > of them. To avoid duplicating code, let's separate interesting > bits of virshDomainShutdownModeCompleter() into a function that > can then be reused. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > tools/virsh-completer.c | 120 ++++++++++++++++++++++++++-------------- > 1 file changed, 77 insertions(+), 43 deletions(-) > > diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c > index 7d5cf8cb90..ef2f39320e 100644 > --- a/tools/virsh-completer.c > +++ b/tools/virsh-completer.c > @@ -69,6 +69,79 @@ > */ > > > +/** > + * virshCommaStringListComplete: > + * @input: user input so far > + * @options: ALL options available for argument > + * > + * Some arguments to our commands accept the following form: > + * > + * virsh command --arg str1,str2,str3 > + * > + * This does not play nicely with our completer funtions, because > + * they have to return strings prepended with user's input. For > + * instance: > + * > + * str1,str2,str3,strA > + * str1,str2,str3,strB > + * str1,str2,str3,strC ^This sounds rather sub-optimal. I wouldn't even insist on making the suggestions contextual like it is now, IOW not suggesting options which have already been specified and would rather return the same list of possible options than a string with the user input prepended.