[libvirt] [PATCH v2 8/9] qemu: add bps_max and friends to qemu command generation
Check the arability of the options with the current qemu binary, add them in the varable
opt if yes,
print a message if not.
Signed-off-by: Matthias Gatto <matthias.gatto(a)outscale.com>
---
src/qemu/qemu_command.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 8a69976..9e84e98 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -3598,6 +3598,55 @@ qemuBuildDriveStr(virConnectPtr conn,
disk->blkdeviotune.write_iops_sec);
}
+ /* block I/O throttling 1.7 */
+ if ((disk->blkdeviotune.total_bytes_sec_max ||
+ disk->blkdeviotune.read_bytes_sec_max ||
+ disk->blkdeviotune.write_bytes_sec_max ||
+ disk->blkdeviotune.total_iops_sec_max ||
+ disk->blkdeviotune.read_iops_sec_max ||
+ disk->blkdeviotune.write_iops_sec_max) &&
+ !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE_IOTUNE_MAX)) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+ _("there is some block I/O throttling paramater that are not
supported with this "
+ "QEMU binary(need QEMU 1.7 or superior)"));
+ goto error;
+ }
+
+ if (disk->blkdeviotune.total_bytes_sec_max) {
+ virBufferAsprintf(&opt, ",bps_max=%llu",
+ disk->blkdeviotune.total_bytes_sec_max);
+ }
+
+ if (disk->blkdeviotune.read_bytes_sec_max) {
+ virBufferAsprintf(&opt, ",bps_rd_max=%llu",
+ disk->blkdeviotune.read_bytes_sec_max);
+ }
+
+ if (disk->blkdeviotune.write_bytes_sec_max) {
+ virBufferAsprintf(&opt, ",bps_wr_max=%llu",
+ disk->blkdeviotune.write_bytes_sec_max);
+ }
+
+ if (disk->blkdeviotune.total_iops_sec_max) {
+ virBufferAsprintf(&opt, ",iops_max=%llu",
+ disk->blkdeviotune.total_iops_sec_max);
+ }
+
+ if (disk->blkdeviotune.read_iops_sec_max) {
+ virBufferAsprintf(&opt, ",iops_rd_max=%llu",
+ disk->blkdeviotune.read_iops_sec_max);
+ }
+
+ if (disk->blkdeviotune.write_iops_sec_max) {
+ virBufferAsprintf(&opt, ",iops_wr_max=%llu",
+ disk->blkdeviotune.write_iops_sec_max);
+ }
+
+ if (disk->blkdeviotune.write_iops_sec_max) {
+ virBufferAsprintf(&opt, ",iops_size=%llu",
+ disk->blkdeviotune.size_iops_sec);
+ }
+
if (virBufferCheckError(&opt) < 0)
goto error;
--
1.8.3.1