Re: [PATCH 2/3] build: make netcf=disabled the default
On 1/22/21 4:51 AM, Daniel P. Berrangé wrote:
On Fri, Jan 22, 2021 at 03:01:56AM -0500, Laine Stump wrote:
> Even after the previous patch, in order to build without netcf you
> would need to add "-Dnetcf=disabled" to the meson commandline (or
> uninstall netcf-devel). This patch makes -Dnetcf=disabled the
> default. (Without this change, a lot of people would just blindly
> continue building with netcf enabled.)
>
> Signed-off-by: Laine Stump <laine(a)redhat.com>
> ---
> meson.build | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
I don't much like this idea. I consider it a bug if I have
installed the -devel package for a pre-requisite and it isn't
then detected.
If a distro no longer wants to support netcf why not just
retire the netcf package from that distro version(s), that
way users won't have it installed in the first place ?
Yeah, that's what patch 3 does. I added this patch in later as a way of
preventing developers (and people who routinely build their own packages
from upstream without using the "rpm" target) from naively continuing to
use a setup that is deprecated (and then wondering why it behaves
differently when the build locally).
I'm okay leaving out this patch and just recommending that everyone do
their own builds, though.