-----Original Message----- From: Ján Tomko [mailto:jtomko@redhat.com] Sent: Tuesday, November 24, 2020 6:57 PM To: tuguoyi (Cloud) <tu.guoyi@h3c.com> Cc: libvir-list@redhat.com Subject: Re: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares
On a Tuesday in 2020, Tuguoyi wrote:
cfg->firmwares still points to the original memory address after being freed by virFirmwareFreeList(). As cfg get freed, it will be freed again even if cfg->nfirmwares=0 which eventually lead to crash.
The patch fix it by setting cfg->firmwares to NULL explicitly after virFirmwareFreeList() returns
Signed-off-by: Tuguoyi <tu.guoyi@h3c.com>
Should there be a space separating your name(s)?
--- src/qemu/qemu_conf.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
Hi there, It's my first time to submit patch to libvirt, so I'm wondering will this patch be applied to the upstream?