On Monday, 14 September 2020 17:33:02 CEST Michal Privoznik wrote:
+ for (dynamicProperty = virtualMachine->propSet; dynamicProperty; + dynamicProperty = dynamicProperty->_next) { + if (STREQ(dynamicProperty->name, "guest.net")) { + if (esxVI_GuestNicInfo_CastListFromAnyType + (dynamicProperty->val, &guestNicInfoList) < 0) { + goto cleanup; + } + } + } + + if (!guestNicInfoList) + goto cleanup;
This looks suspicious. If I understand the code correctly then this means we haven't found any network config. What we usually do is we return an empty array (*ifaces = NULL) and return 0. But if this is a more serious error then we need a virReportError() here.
Good notice, it is actually an issue (we requested a property of a VM, the SOAP call for it succeeded but there was no property in the answer). I will amend and send v2. Thanks, -- Pino Toscano