Re: [libvirt] [PATCH 2/3] tests: invert the return logic in storagepoolcapstest
On Wed, Mar 06, 2019 at 19:16:47 +0100, Pavel Hrdina wrote:
This way if the first test "full" fails we will run the
second test as
well.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
tests/storagepoolcapstest.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
ACK, that's the way almost all our test files use.
Alternatively by using VIR_AUTOUNREF for both 'fullCaps' and 'fsCaps'
you can get rid of the whole cleanup label and just return -1 if any of
the virCapabilitiesNew calls fails. Then use 'ret' only in DO_TEST.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)