Re: [libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

On Tuesday, November 26, 2019, Philippe Mathieu-Daudé <philmd(a)redhat.com&gt; wrote: > > Hi Aleksandar, > > On 11/26/19 9:46 PM, Aleksandar Markovic wrote: >> >> On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé >> <philmd(a)redhat.com&gt; wrote: >>> >>> >>> The r4k machine was introduced in 2005 (6af0bf9c7) and its last >>> logical change was in 2005 (9542611a6). After we can count 164 >>> maintenance commits (QEMU API changes) with the exception of >>> 1 fix in 2015 (memory leak, commit 3ad9fd5a). >>> >>> This machine was introduced as a proof of concept to run a MIPS >>> CPU. 2 years later, the Malta machine was add (commit 5856de80) >>> modeling a real platform. >>> >>> Note also this machine has no specification except 5 lines in >>> the header of this file: >>> >>> * emulates a simple machine with ISA-like bus. >>> * ISA IO space mapped to the 0x14000000 (PHYS) and >>> * ISA memory at the 0x10000000 (PHYS, 16Mb in size). >>> * All peripherial devices are attached to this "bus" with >>> * the standard PC ISA addresses. >>> >>> It is time to deprecate this obsolete machine. Users are >>> recommended to use the Malta board, which hardware is well >>> documented. >>> >>> Signed-off-by: Philippe Mathieu-Daudé <philmd(a)redhat.com&gt; >>> --- >> >> >> Philippe, >> >> I see you added "libvir-list" in "cc". Was it a mistake, or there was >> some purpose? > > > I don't pick the series recipient manually, I send my series with git-publish. Here it used the default QEMU profile. > > All profiles call git-sendmail with the cc-cmd set to the get_maintainer.pl script: > > $ cat .gitpublish > # > # Common git-publish profiles that can be used to send patches to QEMU upstream. > # > # See https://github.com/stefanha/git-publish for more information > # > [gitpublishprofile "default"] > base = master > to = qemu-devel(a)nongnu.org > cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit --nogit-fallback 2>/dev/null > > Having a closer look, libvir-list list was Cc'ed because it is listed as reviewer of the qemu-deprecated.texi file, which was modified. > > ./scripts/get_maintainer.pl -f qemu-deprecated.texi > libvir-list(a)redhat.com (reviewer:Incompatible changes) > qemu-devel(a)nongnu.org (open list:All patches CC here) > OK. No problem. It just looked strange. As far as consuktations, I am just waiting for some responses within company to establish if somebody is perhaps using this machine with some ancient kernel. I got some opinions that are in favor of R4000 machine deprecating, but I need to wait for all relevant departments to confirm. What happened to TileGX?