On Tue, Jul 27, 2010 at 08:48:07AM -0400, Cole Robinson wrote:
On 07/27/2010 06:13 AM, Daniel P. Berrange wrote:
> On Mon, Jul 26, 2010 at 04:31:23PM -0400, Cole Robinson wrote:
>> Add a new element to the <os> block:
>>
>> <bootmenu enable="yes|no"/>
>>
>> Which maps to -boot,menu=on|off on the QEMU command line.
>>
>> I decided to use an explicit 'enable' attribute rather than just make
the
>> bootmenu element boolean. This allows us to treat lack of a bootmenu element
>> as 'use hypervisor default'.
>>
>> Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
>
> I'm wondering what we should do if we need a further option
> to turn on/off the PXE boot menus that SEABIOS now adds to
> QEMU for each NIC. I guess that might be a separate
> <bootmenu> element within the <interface> device so probably
> wouldn't impact this modelling
>
Yeah, I think we eventually need some sort of <boot> element at the
device level anyways, to support booting off hdb instead of hda for
example. But yeah, I don't think it should affect this patch.
Agreed, ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine
http://rpmfind.net/
http://veillard.com/ | virtualization library
http://libvirt.org/