On Fri, May 17, 2019 at 06:45:08PM +0200, Peter Krempa wrote:
On Fri, May 17, 2019 at 15:22:12 +0200, Peter Krempa wrote:
On Fri, May 17, 2019 at 13:24:52 +0100, Daniel Berrange wrote:
This patch series proposes a new way to build a "libvirt QEMU shim" which supports more use cases than the previous approach from last year, as well as being vastly simpler to implement.
Few thoughts:
two more:
[...]
9) Users may have different ideas regarding values in qemu.conf (such as default_tls_x509_cert_dir) thus we probably need a way to provide that one as well separately.
I believe my patch should already deal with that as I prefix all the dirs that the QEMU driver knows about.
10) users almost certainly will want to use a separate instance of the secret driver as there's no other way to define secrets for disks and sharing the instance seems wrong
Yep. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|