Re: [libvirt] [PATCH 5/6] nodedev: Support SCSI_GENERIC cap flag for listAllNodeDevices
On 06/03/2013 06:05 AM, Osier Yang wrote:
---
include/libvirt/libvirt.h.in | 1 +
src/conf/node_device_conf.c | 4 +++-
src/conf/node_device_conf.h | 3 ++-
3 files changed, 6 insertions(+), 2 deletions(-)
ACK....
Seems reasonable - although the last time you updated
virConnectListAllNodeDeviceFlags you also changed libvirt.c to add
VIR_CONNECT_LIST_NODE_DEVICES_CAP_FC_HOST and
VIR_CONNECT_LIST_NODE_DEVICES_CAP_VPORTS to the documented list of flags
in virConnectListAllNodeDevices(). I would think you'd need to add
VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_GENERIC too.
I used cscope search on VIR_CONNECT_LIST_NODE_DEVICES_CAP in order to
find that.
John