"Daniel P. Berrange" <berrange@redhat.com> wrote:
This patch makes the various Xen drivers threadsafe by adding a mutex lock on the xenUnifiedPrivatePtr object. The XenD driver does not really need much locking, since it usually just calls out to XenD. Likewise the Xen driver just makes hypercalls. Locks are needed for libxenstore access, and the xm/inotify drivers since they have shared state
src/proxy_internal.c | 173 ++++++++++++++++----------------- src/xen_inotify.c | 25 +++- src/xen_internal.c | 29 +++-- src/xen_unified.c | 176 +++++++++++++++++++++------------- src/xen_unified.h | 36 +++++-- src/xend_internal.c | 37 ++++++- src/xm_internal.c | 256 +++++++++++++++++++++++++++++++++----------------- src/xs_internal.c | 130 +++++++++++++++++++------ src/xs_internal.h | 7 - tests/sexpr2xmltest.c | 19 +++ 10 files changed, 575 insertions(+), 313 deletions(-)
Looks A-ok to me (yes, it was tedious). ACK. For future reference, it'd be nice to separate the largely mechanical things like s/fprintf/VIR_*/ and s/staticVar/priv->staticVar/ from the more, um, let's say "interesting" changes that make you wish for a good, domain-specific static analyzer.