Re: [libvirt] [PATCH 0/5] Support embedding the QEMU driver in client apps directly

On Fri, May 17, 2019 at 17:49:31 +0100, Daniel Berrange wrote: Hmm, I'm not sure whether just prefixing every path used internally with the passed prefix will be a good idea. Ideally we should keep the directory contents opaque to the user so they don't ever try to mess with the files in the directory. This disqualifies the use of this for passing in the qemu config file. This also reminds me that we need some locking for the directory so that there aren't two processes openning the same prefix and messing up the files internally. It will even not work in some cases because the attempt to reopen the monitor sockets would possibly fail. If not we've got even more of a problem. Also this would mean that a prefix of '/' would be equal to the system instance handled by libvirtd so we need also interlocking with libvirt if we don't change the layout. One disadvantage of this idea is that I can see users that will actually use this to replace libvirt's RPC with something else. This will be caused by the fact that there can be only one process handling each prefix as extending qemu driver to allow concurrent access would be a nightmare.