On Friday, 5 February 2021 15:18:30 CET Daniel P. Berrangé wrote:
+ for (i = 0; i < VIR_DOMAIN_TAINT_LAST; i++) { + if (vm->taint & (1 << i)) { + (*msgs)[n++] = g_strdup_printf( + "%s: %s", _("tainted"),
Please translate the whole string, instead of composing a string puzzle, e.g.: g_strdup_printf(_("tainted: %s"), msg) There are languages that may need to tweak capitalization and/or punctuation of text; for example, in French a space is needed before and after : (colon).
+ if (!flags || (flags & VIR_DOMAIN_MESSAGE_DEPRECATION)) { + nmsgs += vm->ndeprecations; + *msgs = g_renew(char *, *msgs, nmsgs+1); + + for (i = 0; i < vm->ndeprecations; i++) { + (*msgs)[n++] = g_strdup_printf( + "%s: %s", + _("deprecated configuration"), + vm->deprecations[i]);
Ditto. -- Pino Toscano