Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new string

-----Original Message----- From: Martin Kletzander [mailto:mkletzan@redhat.com] Sent: Tuesday, January 14, 2014 9:24 PM To: Chen Hanxiao Cc: libvir-list(a)redhat.com Subject: Re: [libvirt] [PATCH] lxc: do cleanup when failed to create new

On Tue, Jan 14, 2014 at 05:31:03PM +0800, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com&gt; > > Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com&gt; > --- > src/lxc/lxc_process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c > index c51c4d5..fc399fb 100644 > --- a/src/lxc/lxc_process.c > +++ b/src/lxc/lxc_process.c > @@ -1045,7 +1045,7 @@ int virLXCProcessStart(virConnectPtr conn, > > if (virAsprintf(&logfile, "%s/%s.log", > cfg->logDir, vm->def->name) < 0) > - return -1; > + goto cleanup; > I see nothing in that cleanup that needs to be done in this codepath. The only thing which might be needed is cleaning up the vm->def->resource, but that doesn't make much sense to me. Can you explain the change?

Plus the indentation's off.

Thanks, Martin