Re: [libvirt] [PATCH 0/2] add qemu machine type q35 support
On Tue, Jan 8, 2013 at 8:35 PM, liguang <lig.fnst(a)cn.fujitsu.com> wrote:
qemu-1.3 added machine type q35,
changelog said:
Added Intel Q35 chipset as a new machine type,
'--machine q35'. Adds PCIe support. Requires an updated SeaBIOS (bios.bin),
and '-acpitable file=/seabios-path/q35-acpi-dsdt.aml' to run.
so add q35 support for libvirt.
src/conf/device_conf.c | 8 +++++++-
src/conf/device_conf.h | 1 +
src/conf/domain_conf.c | 1 +
src/conf/domain_conf.h | 1 +
src/qemu/qemu_capabilities.c | 11 +++++++++++
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 8 +++-
7 files changed, 29 insertions(+), 2 deletions(-)
I'd personally NACK this series for the time being. Per the qemu
maintainers, q35 isn't really fully ready until 1.4. They're actively
in the process of hashing out the machine type which will be exposed
on the command line and via QMP so I think we really need to wait
until that lands in upstream's repo before we add code for it in
libvirt.
Just my 2c.
--
Doug Goldstein