Re: [libvirt] [PATCH] esx: Reduce code duplication in generator

On 05/01/2013 12:44 PM, Matthias Bolte wrote: > --- > src/esx/esx_vi_generator.py | 430 ++++++++++++------------------------------- > 1 file changed, 118 insertions(+), 312 deletions(-) My python is weak, so I reviewed this by comparing the generated files before and after this patch; added comments in the generated code are nice, but there are also some added frees. Are these additions intentional to fix a leak, or are they representing a bug in your patch? If intentional, then this is 1.0.5 material if you improve the commit message and push in time; if accidental and no real bug is being fixed, then a v2 should wait until after the release.